Skip to content

fix: nctl silently override service with same name - #449

Merged
SaadAssaf merged 1 commit into
mainfrom
service_connection
Sep 7, 2026
Merged

fix: nctl silently override service with same name#449
SaadAssaf merged 1 commit into
mainfrom
service_connection

Conversation

@SaadAssaf

Copy link
Copy Markdown
Contributor

No description provided.

@thirdeyenick thirdeyenick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread internal/application/service.go Outdated
Comment thread internal/application/service.go Outdated
- UpdateServices now matches by name and kind not name alone, so
updating an app across multiple commands keeps both entries.
- --service changed from a map-typed flag to a slice-typed one
@SaadAssaf
SaadAssaf merged commit 90192eb into main Sep 7, 2026
3 checks passed
@SaadAssaf
SaadAssaf deleted the service_connection branch September 7, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants