allow to send html emails on mailgun - #1019
Open
firefart wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for sending HTML email bodies when using the Mailgun notification provider, instead of always sending plain text.
Changes:
- Introduce an internal Mailgun “mode” (text vs HTML) with a default of plain text.
- Add a
WithHTML()option to configure the Mailgun service to send HTML bodies. - Update
Send()to build either a plain-text message or an HTML message based on the configured mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
service/mailgun/options.go |
Adds WithHTML() option to configure HTML mode for outgoing messages. |
service/mailgun/mailgun.go |
Adds mode state and updates Send() to construct a text or HTML Mailgun message accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changes allows to send HTML emails with the mailgun provider. Currently all emails are hardcoded to plain text emails.
Motivation and Context
I want to send HTML emails using the mailgun provider
How Has This Been Tested?
locally
Screenshots / Output (if appropriate):
Types of changes
Checklist: