Skip to content

Add 'strandedness' to permitted meta keys - #4473

Merged
maxulysse merged 6 commits into
devfrom
allow_meta_strandedness
Sep 18, 2026
Merged

Add 'strandedness' to permitted meta keys#4473
maxulysse merged 6 commits into
devfrom
allow_meta_strandedness

Conversation

@pinin4fjords

@pinin4fjords pinin4fjords commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Following discussion in Maintainers team, allow 'strandedness' as an allowed meta field.

Updates test_validate_meta_keys to match.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

mashehu and others added 2 commits July 29, 2026 16:04
@mashehu @renovate
@nf-core-bot @claude @JulianFlesch @muffato @ningyuxin1999 JosuaCarl-Agents @codspeedbot @LouisLeNezet @nvnieuwk @pinin4fjords @beatrizsavinhas @apeltzer @Aratz @ewels @maxulysse @simojoe @binggao1230 @jfy133 @znorgaard @JosuaCarl @sanmaxdev @codspeed @DLBPointon @MatthiasZepper
dev -> main for 4.1.0 (#4429)
eb2f709 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: mashehu <mashehu3@gmail.com>
Co-authored-by: nf-core-bot <core@nf-co.re>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: JulianFlesch <julianflesch@googlemail.com>
Co-authored-by: Matthieu Muffato <mm49@sanger.ac.uk>
Co-authored-by: yuxinNing <ningyuxin1999@126.com>
Co-authored-by: yuxinNing <92061677+ningyuxin1999@users.noreply.github.com>
Co-authored-by: JosuaCarl-Agents <josua.carl@web.de>
Co-authored-by: CodSpeed Bot <no-reply@codspeed.io>
Co-authored-by: louis <louislenezet@gmail.com>
Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com>
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
Co-authored-by: Jonathan Manning <jonathan.manning@seqera.io>
Co-authored-by: Beatriz Vinhas <beatriz.sa.vinhas@gmail.com>
Co-authored-by: Nicolas Vannieuwkerke <nicolas.vannieuwkerke@ugent.be>
Co-authored-by: Alexander Peltzer <apeltzer@users.noreply.github.com>
Co-authored-by: Adrien Coulier <adrien.coulier@pixelgen.com>
Co-authored-by: Phil Ewels <phil.ewels@seqera.io>
Co-authored-by: Maxime U Garcia <max.u.garcia@gmail.com>
Co-authored-by: simojoe <37026683+simojoe@users.noreply.github.com>
Co-authored-by: Joël Simoneau <simoneaujoel@gmail.com>
Co-authored-by: Vincent Gao <gaobing1230@gmail.com>
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Co-authored-by: JulianFlesch <julian.flesch@qbic.uni-tuebingen.de>
Co-authored-by: znorgaard <zach@fulcrumgenomics.com>
Co-authored-by: Josua Carl <53010862+JosuaCarl@users.noreply.github.com>
Co-authored-by: sanmaxdev <sanmaxdev@users.noreply.github.com>
Co-authored-by: Sangeeth Thilakarathna <46221775+sanmaxdev@users.noreply.github.com>
Co-authored-by: codspeed-hq[bot] <117304815+codspeed-hq[bot]@users.noreply.github.com>
Co-authored-by: Damon-Lee Pointon <51855558+DLBPointon@users.noreply.github.com>
Co-authored-by: Matthias Zepper <6963520+MatthiasZepper@users.noreply.github.com>
@pinin4fjords
Add 'strandedness' to permitted meta keys
b1cbae6
@codecov

codecov Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.20%. Comparing base (b9d9e05) to head (4bc8dc8).

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pinin4fjords
test: fix meta key validation test for strandedness
460b288 
The invalid-keys case used meta.strandedness as an example, but this
PR adds strandedness to the permitted set, so it no longer triggers a
lint failure. Swap it for meta.region and add a strandedness case to
the valid-keys assertion to exercise the actual change.
@pinin4fjords
pinin4fjords marked this pull request as draft September 17, 2026 10:55
@maxulysse
maxulysse changed the base branch from main to dev September 18, 2026 07:59
@maxulysse

maxulysse commented Sep 18, 2026

Copy link
Copy Markdown
Member

@nf-core-bot fix linting pretty please 🙏

@github-actions

github-actions Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

⚠️ Cannot proceed with deployment

No matching environment target found. Please check your command and try again. You can read more about environment targets in the README of this Action.

The following environment targets are available: production,development,staging

maxulysse
maxulysse reviewed Sep 18, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
@ewels
ewels marked this pull request as ready for review September 18, 2026 09:12
@ewels

ewels commented Sep 18, 2026

Copy link
Copy Markdown
Member

Presumably needs docs on the website too.

@maxulysse maxulysse mentioned this pull request Sep 18, 2026
Merged
@maxulysse
maxulysse merged commit d91668e into dev Sep 18, 2026
123 checks passed
@maxulysse
maxulysse deleted the allow_meta_strandedness branch September 18, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse left review comments
@ewels ewels ewels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pinin4fjords @maxulysse @ewels @mashehu @nf-core-bot