feat(cellranger/count): support SRA three-file FASTQ inputs (_1/_2/_3) in renaming logic - #532
Open
emrunali wants to merge 2 commits into
Open
feat(cellranger/count): support SRA three-file FASTQ inputs (_1/_2/_3) in renaming logic#532emrunali wants to merge 2 commits into
emrunali wants to merge 2 commits into
Conversation
Release version 4.1.0 of pipeline
Handle fasterq-dump --split-files --include-technical output by mapping _2/_3 to R1/R2 and optionally renaming _1 to I1. Made-with: Cursor
Member
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.4.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
fmalmeida
requested changes
Mar 14, 2026
Contributor
There was a problem hiding this comment.
Hi @emrunali ,
Many thanks for the work in it.
The cellranger module is a nf-core module, thus the work / changes cannot happen directly in the pipeline side.
They should happen first in the modules repo, and then, the pipeline will only be modified to fetch the latest version.
So, I will not be accepting this PR so we can review in the correct repo .
😄
Author
|
Thanks @fmalmeida, will do as you suggested. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the
cellranger countmodule’s FASTQ renaming logic to handle SRA /fasterq-dumpoutputs that produce three files per sample (*_1/_2/_3.fastq(.gz)), which is common for 10x chemistries when run with--split-files --include-technical.Specifically:
_1,_2,_3in filenames._2and_3are present, map:_2→R1(barcode+UMI),_3→R2(cDNA),_1(if present) →I1(sample index).R1/R2filenames unchanged._1/_2/_3) can be recognised.No changes were required in
modules/nf-core/cellranger/count/main.nf; all logic is contained withincellranger_count.py.Motivation / use case
Many public 10x datasets are only available in SRA. When using: