Repository navigation
Conversation
4 of 8 tasks
susnux
approved these changes
Nov 5, 2026
AndyScherzinger
approved these changes
Nov 5, 2026
Instead of looking up the share target name in the received federated shares and checking the node afterwards, only consider nodes that are the root of a federated share mounted for the share owner and use the mount point of that node for the lookup. This also recognises federated shares that were moved into a subfolder as reshares, so they are reshared through their remote owner. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
refactor/federated-reshare-by-mount
branch
from
November 5, 2026 13:02
aed9d45 to
5dc8b06
Compare
skjnldsv
enabled stacked auto-merge
November 5, 2026 13:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #66360. Instead of looking up the target name and checking the node afterwards, only a node that is the root of a federated share mounted for the share owner is looked up, using that node's own mount point.
Note
Behaviour change: a received federated share that was moved into a subfolder is now also recognised as a reshare and goes through its remote owner. Before, it was shared as a plain federated share from this instance.
Existing tests updated. The moved-mount case has no dedicated test yet.
Checklist
3. to review, feature component)stable32)AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.