Repository navigation
fix(settings): handle unavailable OPcache status and clarify sizing advice - #66149
Draft
joshtrichards wants to merge 1 commit into
Draft
joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
Run independent OPcache configuration checks before returning from usage checks so their findings are preserved when status retrieval is disabled or fails. Return immediately when opcache_get_status() returns false, avoiding invalid array access and false interned-string exhaustion warnings. Distinguish unavailable usage statistics and numeric settings from zero values. Skip dedicated interned-string buffer checks when its configured size is zero, and report unavailable sizing information when observed usage indicates pressure. Match opcache_get_status exactly in disable_functions and report when usage checks are skipped. Clarify key-limit and shared-memory recommendations while preserving their purpose and sizing context. Revise comments about cache_full and wasted-memory restart conditions. Assisted-by: Copilot:gpt-6.1-sol Signed-off-by: Josh <josh.t.richards@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve OPcache setup diagnostics without changing the existing cache-full gate, exact key-limit comparison, or interned-string usage/sizing thresholds.
opcache_get_status()fails, preventing invalid array access and false interned-string warnings.opcache_get_statusexactly indisable_functionsand explain when usage checks are skipped.cache_fullcoverage, and wasted-memory restart conditions.Admin-visible behavior
Failed status retrieval no longer produces misleading interned-string exhaustion advice.
Unavailable usage statistics or sizing values are reported explicitly where needed. A configured zero-sized dedicated interned-string buffer does not itself produce a warning.
Disabling
opcache_get_statusthroughdisable_functionsnow produces an explicit warning; previously, usage checks were skipped silently.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)