Repository navigation
[stable34] fix(appstore): do not wrap app store screenshots in the proxy twice - #65990
Merged
Merged
Conversation
backportbot
Bot
added
bug
3. to review
backportbot
Bot
requested review from
leftybournes,
provokateurin and
salmart-dev
October 28, 2026 20:56
benjaminfrueh
approved these changes
Oct 29, 2026
edward-ly
approved these changes
Oct 29, 2026
edward-ly
force-pushed
the
backport/64771/stable34
branch
from
October 29, 2026 16:45
a82776b to
f353adb
Compare
edward-ly
enabled auto-merge
October 29, 2026 16:52
The app store now serves screenshot URLs already pointing at usercontent.apps.nextcloud.com. Wrapping them again names a file the proxy never stores the image under, so no app shows its screenshot. Pass such URLs through unchanged, and encode the others with the URL-safe alphabet the proxy stores its files under. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Martin Rüegg <martin.rueegg@metaworx.ch>
Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
force-pushed
the
backport/64771/stable34
branch
from
November 2, 2026 17:40
9a7a6bc to
ba3e14e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #64771