Repository navigation
[stable35] fix(files_reminders): keep folder preload for folders over 512 entries - #65476
Open
backportbot[bot] wants to merge 1 commit into
Open
backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
backportbot
Bot
added
bug
3. to review
skjnldsv
approved these changes
Oct 13, 2026
Merged
Merged
AndyScherzinger
force-pushed
the
backport/64706/stable35
branch
from
November 4, 2026 22:02
3be281c to
5814630
Compare
AndyScherzinger
requested review from
GhassenKefi and
pabzm
and removed request for
a team
November 4, 2026 22:02
sorbaugh
approved these changes
Nov 5, 2026
susnux
requested changes
Nov 5, 2026
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
CI related, needs to be adjusted for Nextcloud 35.
- OCA\FilesReminders\Tests\Service\ReminderServiceTest::testCreateAfterPreloadIsReturned
PHPUnit\Framework\MockObject\Generator\UnknownTypeException: Class or interface "OCP\Files\IUserFolder" does not exist/home/runner/actions-runner/_work/server/server/apps/files_reminders/tests/Service/ReminderServiceTest.php:86
/home/runner/actions-runner/_work/server/server/apps/files_reminders/tests/Service/ReminderServiceTest.php:148
- OCA\FilesReminders\Tests\Service\ReminderServiceTest::testUpdateAfterPreloadIsReturned
PHPUnit\Framework\MockObject\Generator\UnknownTypeException: Class or interface "OCP\Files\IUserFolder" does not exist/home/runner/actions-runner/_work/server/server/apps/files_reminders/tests/Service/ReminderServiceTest.php:86
/home/runner/actions-runner/_work/server/server/apps/files_reminders/tests/Service/ReminderServiceTest.php:165
- OCA\FilesReminders\Tests\Service\ReminderServiceTest::testRemoveAfterPreloadIsNotReturned
PHPUnit\Framework\MockObject\Generator\UnknownTypeException: Class or interface "OCP\Files\IUserFolder" does not exist/home/runner/actions-runner/_work/server/server/apps/files_reminders/tests/Service/ReminderServiceTest.php:86
/home/runner/actions-runner/_work/server/server/apps/files_reminders/tests/Service/ReminderServiceTest.php:182
_
| use OCP\Cache\CappedMemoryCache; | ||
| use OCP\Files\Folder; | ||
| use OCP\Files\IRootFolder; | ||
| use OCP\Files\IUserFolder; |
ReminderService::cacheFolder() stored one entry per child in the in-memory cache, which is capped at 512 entries. Listing a folder with 512 or more children evicted entries before the DAV plugin read them, so each evicted file fell back to its own query. Keep the folder preload in a separate per-request map and drop the entry whenever a reminder is written, so later changes in the same request win. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
backport/64706/stable35
branch
from
November 5, 2026 14:47
5814630 to
c95cd52
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #64706