Skip to content

fix(files_sharing): public share popover jumps on options toggle - #65142

Open
ShGKme wants to merge 1 commit into
masterfrom
fix/files_sharing__prevent-popover-dialog-flip
Open

ShGKme wants to merge 1 commit into
masterfrom
fix/files_sharing__prevent-popover-dialog-flip

Conversation

@ShGKme

@ShGKme ShGKme commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Public share creation popover dialog has dynamically added elements like password and date expiration
  • On some screen sizes toggling them results in the popover jump (flip)
  • placement="auto" fixes the issue
    • Now it is always on the side and moves freely on size change
    • Unlike many other places, it looks well because the trigger is on the page edge
  • I don't think a more general solution is needed:
    • The only other similar place on server is the weather status widget, which is less disturbing
  • NcPopover's flip=false or shiftCrossAxis do not help. They prevent jump by allowing overflowing...
Before After
before after

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the Nextcloud 36 milestone Oct 5, 2026
@ShGKme
ShGKme requested review from provokateurin and susnux October 5, 2026 14:28
@ShGKme ShGKme self-assigned this Oct 5, 2026
@ShGKme
ShGKme requested a review from a team as a code owner October 5, 2026 14:28
@ShGKme
ShGKme requested review from kristian-zendato and sorbaugh and removed request for a team October 5, 2026 14:28

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants