Repository navigation
[stable35] fix(settings): let a failed app token creation surface to the user - #65141
Merged
Merged
Conversation
addToken swallowed every error from the request and returned null, so the catch in AuthTokenSetup never ran. Creating an app password against a blocked or failing endpoint left the form silently doing nothing. Drop the catch and let the rejection reach the caller, which already logs it and shows an error, the same way updateToken leaves reporting to its callers. Fixes #62680 Signed-off-by: ELHart05 <o.allaoua@esi-sba.dz>
backportbot
Bot
requested review from
joshtrichards,
kristian-zendato,
skjnldsv,
sorbaugh and
susnux
and removed request for
a team
October 5, 2026 14:16
backportbot
Bot
added
bug
3. to review
backportbot
Bot
added
bug
3. to review
susnux
approved these changes
Oct 5, 2026
joshtrichards
approved these changes
Oct 5, 2026
joshtrichards
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #63189