Skip to content

refactor(settings): migrate the app password section to Vue 3 - #65018

Merged
susnux merged 6 commits into
masterfrom
chore/noid/authtokens-vue3
Oct 6, 2026
Merged

refactor(settings): migrate the app password section to Vue 3#65018
susnux merged 6 commits into
masterfrom
chore/noid/authtokens-vue3

Conversation

@pringelmann

@pringelmann pringelmann commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Personal settings > security > devices & sessions now Vue 3, rest of settings stays Vue 2 for now
  • This is groundwork to unblock upcoming app password UI changes
  • Remaining settings migration work to follow soon

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (reviewed and manually tested by me)

@pringelmann
pringelmann force-pushed the chore/noid/authtokens-vue3 branch from 995e1df to b0ab17c Compare October 5, 2026 13:33
@pringelmann pringelmann changed the title refactor(settings): move the app password section into its own folder refactor(settings): migrate the app password section to Vue 3 Oct 5, 2026
@pringelmann pringelmann self-assigned this Oct 5, 2026
@pringelmann
pringelmann force-pushed the chore/noid/authtokens-vue3 branch from b0ab17c to b90a6e5 Compare October 6, 2026 08:33
@pringelmann pringelmann added 3. to review Waiting for reviews feature: settings technical debt 🧱 🤔🚀 ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Oct 6, 2026
@pringelmann pringelmann added this to the Nextcloud 36 milestone Oct 6, 2026
@pringelmann
pringelmann marked this pull request as ready for review October 6, 2026 08:34
@pringelmann
pringelmann requested review from a team as code owners October 6, 2026 08:34
@pringelmann
pringelmann requested review from CarlSchwan, come-nc, icewind1991, kristian-zendato, skjnldsv, sorbaugh and susnux and removed request for a team October 6, 2026 08:34
@pringelmann
refactor(settings): move the app password section into its own folder
d66483a 
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@pringelmann
refactor(settings): migrate the app password section to Vue 3
54faa73 
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@pringelmann
fix(settings): return focus after renaming an app password
9e09e51 
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
susnux
susnux approved these changes Oct 6, 2026
View reviewed changes

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but did not test

@pringelmann
fix(settings): hide the app password QR code from screen readers
fb1762d 
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@pringelmann
refactor(settings): migrate the app password section to script setup
17832b2 
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@pringelmann
pringelmann force-pushed the chore/noid/authtokens-vue3 branch from b90a6e5 to 17832b2 Compare October 6, 2026 18:20
skjnldsv
skjnldsv reviewed Oct 6, 2026
View reviewed changes
Comment thread apps/settings/src/authtokens/components/AuthTokenSection.vue Outdated
@susnux @skjnldsv
chore: properly type
2b5f7e6 
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux merged commit 25459c2 into master Oct 6, 2026
155 checks passed
@susnux
susnux deleted the chore/noid/authtokens-vue3 branch October 6, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes
@skjnldsv skjnldsv skjnldsv approved these changes
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend
@kristian-zendato kristian-zendato Awaiting requested review from kristian-zendato kristian-zendato is a code owner automatically assigned from nextcloud/server-frontend
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend
@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

@pringelmann pringelmann

Labels

3. to review Waiting for reviews AI assisted feature: settings ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt 🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

4 participants

@pringelmann @susnux @skjnldsv @nextcloud-command