add invitation - #863
Open
nananankona wants to merge 12 commits into
Open
Conversation
Member
|
Thanks! Will review when I get the time. Do you mind rebasing so that the CI passes ? You may drop the |
tcitworld
self-requested a review
September 1, 2026 21:03
…limits- Add invitation links (/apps/registration/invite/{code}) with optional email/domain restriction, storage quota, maximum number of uses and expiry date; the usage counter is incremented and the quota applied when an account is created- Add allowed email addresses setting (in addition to allowed domains)- Add option to require an invitation code for all registrations- Add invitation management UI to the admin settings
Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
… bypass- Add skip_email_verification option to invitations: registrations via such an invitation skip the email verification step and go straight to the account creation form- Show the invitation code and shareable link in a dialog after creating an invitation, each with a copy button; add a Details button to the invitation list for the same dialog- Add Japanese translations (l10n/ja) for the invitation strings Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
…time-typed expires/created_at fields can be returned as DateTimeobjects from the entity, which JSON-encode as objects and break thefrontend formatting (TypeError: b.replace is not a function). Normalizedates to Y-m-d H:i:s strings in the controller and harden isExpired andformatDate against non-string values. Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
…skip_email_verification flag can return null from the entity when thecolumn is missing or unset, which broke the bool return type ofinvitationSkipsVerification() with a TypeError on invite links. Defaultthe flag to false in the entity constructor and compare with === trueinstead of relying on the raw value. Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
The backtick-quoted uses + 1 expression breaks on PostgreSQL and Oracle, which do not accept backticks as identifier quotes. Use the unquoted column reference instead (uses is not a reserved word). Also guard domainMatches() against email addresses without an @ sign, which previously raised an undefined key warning and a TypeError in the wildcard branch instead of a clean RegistrationException. Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
Nextcloud forbids BOOLEAN columns with NOT NULL (see MigrationService::ensureOracleConstraints and nextcloud/server#45576). Follow the pattern used by nextcloud/mail and declare the invitation flags as nullable booleans instead. Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
Nextcloud requires index names to be 30 characters or shorter (see MigrationService::ensureOracleConstraints). Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
With the default primary key name the table name (minus prefix) must be shorter than 23 chars. registration_invitation is exactly 23 chars, so set an explicit name instead (see MigrationService::ensureOracleConstraints). Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
Use IQueryBuilder::getColumnName() so the identifier is quoted per platform (Oracle folds unquoted identifiers to upper case, MySQL does not accept backticks on other platforms). Fixes ORA-00904 on Oracle. Signed-off-by: nananankona <185404318+nananankona@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow-list with email domains (including wildcard) or exact email addresses to register with
Invitation codes and invitation links: restrict who can register, limit the number of uses per link, set a storage quota for invited users and optionally skip the email verification step