Skip to content

feat(appointments): default Create Talk room on for new configs - #9052

Open
whoalin1 wants to merge 1 commit into
nextcloud:mainfrom
whoalin1:feat/appointments-talk-room-opt-out
Open

whoalin1 wants to merge 1 commit into
nextcloud:mainfrom
whoalin1:feat/appointments-talk-room-opt-out

Conversation

@whoalin1

@whoalin1 whoalin1 commented Oct 6, 2026 •

Copy link
Copy Markdown

Summary

New appointment schedules left createTalkRoom unset (falsy), so the “Create a Talk room” checkbox started unchecked and users had to opt in every time.

AppointmentConfig.createDefault() now sets createTalkRoom: true so Talk rooms are opt-out. Users can still uncheck the box. Existing configs are unchanged. When Talk is not available, AppointmentConfigModal already forces the option off.

Closes #5774

Test plan

  • With Talk enabled: open Appointments → create a new schedule → “Create a Talk room” is checked by default
  • Uncheck the box, save → no Talk room created for bookings on that schedule
  • With Talk disabled/unavailable: new schedule still opens; Talk option stays off (modal clears it)
  • Edit an existing schedule that had Talk off → checkbox remains off (defaults only apply to createDefault)

AI disclosure

This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.

The commits don't carry Assisted-by: trailers yet; I can add them if wanted (that needs a force push).

Signed-off-by: whoalin1 <whoalin414@gmail.com>
GVodyanov
GVodyanov previously approved these changes Oct 8, 2026

@GVodyanov GVodyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@GVodyanov
GVodyanov self-requested a review October 8, 2026 12:35
@GVodyanov
GVodyanov dismissed their stale review October 8, 2026 12:35

Needs further consideration

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Talk converstations opt-out

2 participants