Skip to content

chore: Reverted adding fake configurations to test json schema generation - #4242

Merged
bizob2828 merged 1 commit into
mainfrom
revert-json-tests
Aug 19, 2026
Merged

chore: Reverted adding fake configurations to test json schema generation#4242
bizob2828 merged 1 commit into
mainfrom
revert-json-tests

Conversation

@bizob2828

Copy link
Copy Markdown
Member

Description

I wanted to rebase main to remove the commits but we have org level branch protection. This PR reverts the PRs to add a fake configuration and updating the json schema

@bizob2828
bizob2828 merged commit 0ce21e9 into main Aug 19, 2026
111 checks passed
@bizob2828
bizob2828 deleted the revert-json-tests branch August 19, 2026 20:47
@github-project-automation github-project-automation Bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Aug 19, 2026
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (5381e27) to head (0a2b5e1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4242      +/-   ##
==========================================
- Coverage   97.52%   97.44%   -0.08%     
==========================================
  Files         521      521              
  Lines       63033    63026       -7     
  Branches        1        1              
==========================================
- Hits        61473    61417      -56     
- Misses       1560     1609      +49     
Flag Coverage Δ
integration-tests-cjs-22.x 73.66% <ø> (-0.01%) ⬇️
integration-tests-cjs-24.x 74.24% <ø> (-0.01%) ⬇️
integration-tests-cjs-26.x 74.24% <ø> (-0.01%) ⬇️
integration-tests-esm-22.x 54.63% <ø> (-0.01%) ⬇️
integration-tests-esm-24.x 55.93% <ø> (-0.01%) ⬇️
integration-tests-esm-26.x 55.93% <ø> (-0.01%) ⬇️
unit-tests-22.x 89.16% <ø> (-0.01%) ⬇️
unit-tests-24.x 89.11% <ø> (+<0.01%) ⬆️
unit-tests-26.x 89.11% <ø> (-0.01%) ⬇️
versioned-tests-22.x 97.44% <ø> (-0.08%) ⬇️
versioned-tests-24.x 97.44% <ø> (-0.08%) ⬇️
versioned-tests-26.x 97.44% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot mentioned this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done: Issues recently completed

Development

Successfully merging this pull request may close these issues.

3 participants