refactor: Split BedrockResponse and BedrockCommand into Converse and InvokeModel variants - #4235
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4235 +/- ##
==========================================
- Coverage 97.52% 97.45% -0.07%
==========================================
Files 521 525 +4
Lines 62972 63174 +202
Branches 1 1
==========================================
+ Hits 61416 61569 +153
- Misses 1556 1605 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
amychisholm03
marked this pull request as ready for review
August 19, 2026 15:23
jsumners-nr
reviewed
Aug 21, 2026
amychisholm03
force-pushed
the
bedrock-refactor
branch
from
August 24, 2026 14:36
a76faa8 to
99cc80a
Compare
github-project-automation
Bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While I was triaging a customer's reported bug with AWS Bedrock, I noticed that the
BedrockResponseandBedrockCommandclasses have gotten a bit complex and hard to reason about. So I splitBedrockResponseintoInvokeModelResponseandConverseResponseand likewise withBedrockCommand. We can deduce which API it is (InvokeModelvs.Converse) when we wrap the Bedrock middleware because we have access to the initial command name there.How to Test
Related Issues
Discovered while researching #4230