Skip to content

refactor: Refactored dns instrumentation to subscribe to events emitted - #4224

Draft
bizob2828 wants to merge 2 commits into
newrelic:mainfrom
bizob2828:dns-migration
Draft

refactor: Refactored dns instrumentation to subscribe to events emitted#4224
bizob2828 wants to merge 2 commits into
newrelic:mainfrom
bizob2828:dns-migration

abstracted into a common core subscriber class

c9d6da5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 19, 2026 in 1s

97.45% (-0.08%) compared to 5fe5da2

View this Pull Request on Codecov

97.45% (-0.08%) compared to 5fe5da2

Details

Codecov Report

❌ Patch coverage is 99.59016% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.45%. Comparing base (5fe5da2) to head (c9d6da5).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lib/subscribers/core/base.js 99.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4224      +/-   ##
==========================================
- Coverage   97.52%   97.45%   -0.08%     
==========================================
  Files         522      526       +4     
  Lines       62949    63234     +285     
  Branches        1        1              
==========================================
+ Hits        61390    61622     +232     
- Misses       1559     1612      +53     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.