Repository navigation
Use headless viewers in layer and save widget unit tests - #1128
Open
SahilKumar75 wants to merge 2 commits into
Open
SahilKumar75 wants to merge 2 commits into
SahilKumar75 wants to merge 2 commits into
Conversation
SahilKumar75
marked this pull request as ready for review
September 30, 2026 15:14
Author
|
Extended this to eight save widget unit cases and the callback connection test. The save widget still uses real Qt buttons and signals, with qtbot handling cleanup. Only the viewer is headless. File round trips, save failures and docked widget lifecycle tests still use the full viewer. All 352 plugin tests passed locally on macOS with napari 0.9.2. Repository hooks passed too. The earlier local OpenGL blocker did not recur in this native Qt run. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Move the existing headless napari viewer fixture into the shared fixture module and use it for the layer style tests that only exercise Shapes layer state.
This reduces unnecessary Qt viewer construction while preserving the Qt backed fixture for widget lifecycle and integration coverage.
Motivation and Context
This is the first focused part of issue 1111. The migrated tests only require
ViewerModeland do not interact with Qt widgets.Closes no issue. Progresses #1111.
How Has This Been Tested?
The complete layer wiring module reaches unchanged Qt viewer tests and then crashes during macOS OpenGL initialization. The migrated headless tests pass independently.
Additional context
The repository does not contain a pull request template. This change follows the contribution guide by keeping the scope focused, linking the issue, and reporting exact validation results.