Repository navigation
Use subprocess and bump benchmark time - #104
Merged
Merged
Conversation
`test_correct_pkg_version_logged` patched `shutil.which` to None to force the library down its pip branch, then ran `python -m pip list` itself with `check=True`. On CI the reusable action installs tox-uv, so tox builds its environments with `uv venv`, which does not install pip -- the test's own pip call exited 1 and the library logged "Could not find conda, pip or uv packages". Drop the patch and pick the backend the same way the library does (conda, then uv, then pip), so the test compares the log against whatever actually ran. The individual branches remain covered in isolation by the mocked tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 77.40% 78.12% +0.72%
==========================================
Files 3 3
Lines 208 224 +16
==========================================
+ Hits 161 175 +14
- Misses 47 49 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
IgorTatarnikov
requested review from
adamltyson and
alessandrofelder
and removed request for
alessandrofelder
August 25, 2026 14:16
alessandrofelder
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
d158de1 changed the package fetching strategy to loop over
importlib.distributionstructure. This allowed venv without pip to check the instlalled packages but made the boot time slower. This returns the package fetching strategy to useuvandpipin that order. It also temporarily boosts the benchmark time to 0.1 rather than 0.05.References
Closes #103
#101
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Tested locally, added new tests.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: