Repository navigation
Add third party logging settings - #102
Merged
Merged
Conversation
adamltyson
approved these changes
Aug 18, 2026
adamltyson
left a comment
Member
There was a problem hiding this comment.
Thanks @IgorTatarnikov shall we release a new version?
Member
|
I think the tests are just failing due to #101, but there's some mention of conda too. |
Member
Author
|
I can't reproduce the second test failure locally, perhaps it's OS specific. I'll try on Ubuntu. |
Member
Author
|
For some reason |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
Some third party libraries can raise logs that are formatted in a way that leads to crashes during logging.
See https://github.com/brainglobe/brainreg/actions/runs/32001242782/job/95302126850
What does this PR do?
Adds two new kwargs:
third_party_loggersandthird_party_level. This allows passing a sequence ofthird_party_loggersto set DEBUG level to a different level than the main level.How has this PR been tested?
Tests have been added, this fix also works with
brainregIs this a breaking change?
No, kwargs only.
Does this PR require an update to the documentation?
No
Checklist: