Skip to content

Add third party logging settings - #102

Merged
IgorTatarnikov merged 2 commits into
mainfrom
add-third-party-log-level
Aug 19, 2026
Merged

IgorTatarnikov merged 2 commits into
mainfrom
add-third-party-log-level

Conversation

@IgorTatarnikov

Copy link
Copy Markdown
Member

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Some third party libraries can raise logs that are formatted in a way that leads to crashes during logging.

See https://github.com/brainglobe/brainreg/actions/runs/32001242782/job/95302126850

What does this PR do?
Adds two new kwargs: third_party_loggers and third_party_level. This allows passing a sequence of third_party_loggers to set DEBUG level to a different level than the main level.

How has this PR been tested?

Tests have been added, this fix also works with brainreg

Is this a breaking change?

No, kwargs only.

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The code has been formatted with pre-commit

@IgorTatarnikov
IgorTatarnikov requested a review from a team August 18, 2026 14:26

@adamltyson adamltyson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IgorTatarnikov shall we release a new version?

@adamltyson

Copy link
Copy Markdown
Member

I think the tests are just failing due to #101, but there's some mention of conda too.

@IgorTatarnikov

Copy link
Copy Markdown
Member Author

I can't reproduce the second test failure locally, perhaps it's OS specific. I'll try on Ubuntu.

@IgorTatarnikov

Copy link
Copy Markdown
Member Author

For some reason pip packages aren't being logged on CI. I've raised #103 to track, but I think this can be merged now.

@IgorTatarnikov
IgorTatarnikov merged commit 92dfb75 into main Aug 19, 2026
17 of 37 checks passed
@IgorTatarnikov
IgorTatarnikov deleted the add-third-party-log-level branch August 19, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants