Conversion tool improvement - #13
Closed
tea2x wants to merge 9 commits into
Closed
Conversation
Contributor
|
Hey thanks for this! I do want to mention that I'm rearchitecting this lock these days, feel free to check out #14 for progresses. Unfortunately, some of our work overlap(e.g., Rust related part), what do you say we revisit this PR when the overhaul is done? |
Contributor
Author
|
Hi @xxuejie it's nothing.
Yes please! |
Contributor
Author
|
it's actually not much in this PR so you might want to just update directly in #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great project! This PR contains some improvements: