Add FreeBSD CI (verification run, do not merge) - #1
Closed
neilpang wants to merge 2 commits into
Closed
Conversation
Cirrus CI shut down on 2026-06-01, which removed the FreeBSD unit test coverage. Run the same test command in a FreeBSD VM booted under QEMU/KVM on a regular ubuntu-latest runner, keeping the skips .cirrus.yml carried. The suite runs as an unprivileged user: src/su/context.rs notes that invalid_shell is allowed to fail under root, and the VM logs in as root.
get_process_start_time compared a ProcessCreateTime against a value built by destructuring SystemTime, which bypasses the newtype that keeps the two clock bases apart. That is a no-op on Linux and fails deterministically on FreeBSD, where kinfo_proc.ki_start is absolute wall clock while CLOCK_BOOTTIME is an alias for the uptime clock. Restore the cfg-aware ProcessCreateTime::now() helper removed in 62d1d30 and document why it cannot be folded into SystemTime::now(), which must keep reading the monotonic clock (see trifectatechfoundation#1022).
neilpang
force-pushed
the
ci/freebsd-vmactions
branch
from
August 2, 2026 03:16
126ab1d to
6079f0c
Compare
Owner
Author
|
Verification run only -- this existed to prove the workflow green on real GitHub Actions before proposing it upstream. The upstream PR is trifectatechfoundation#1663. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal run to verify before proposing upstream to trifectatechfoundation#1543.