feat: allow not backed up VMs to be ignored for backup check - #81
Merged
Merged
Conversation
Owner
|
After some thinking about alternatives (like ignoring vms by their pool or vmid), this sounds like a reasonable feature request. I'm only thinking about a better naming for the ignore switch than |
nbuchwitz
self-requested a review
January 26, 2026 15:24
Add new flag '--ignore-no-backup' to allow users to ignore not backed up VMs in the backup check. The backup check may return a warning state if not backed up VMs are found, however this may be intentional (backup not needed, backup with different mechanism, ...).
Contributor
Author
|
I have amended the edit to reflect the requested change for the switch name 👍 |
Owner
|
Thanks! Can you please also update the README with the changes? |
Adds the `--ignore-no-backup` switch to the Usage section of the Readme. Adds a small usage example to the Check VZDump Backups section of the Readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new flag
--ignore-no-backupto allow users to ignore not backed up VMs in the backup check. The backup check may return a warning state if not backed up VMs are found, however this may be intentional (backup not needed, backup with different mechanism, ...).Use case, why this has been created: At our company we have several temporary or permanent test VMs, which we don't want backed up. The backup-check returns a warning state for those, as they are intentionally unconfigured. Since some VMs are temporary, the VM-IDs are not fixed and reconfiguring the check commands every time the state or amount of test VMs changes would be burdensome.
Hence we propose this change of simply letting any unconfigured VMs being ignored.