ci: build and release macOS Intel (x86_64) bundle - #655
Open
XueyanZhang wants to merge 1 commit into
Open
Conversation
The build matrix only produced an Apple Silicon (aarch64) macOS bundle, so releases shipped no Intel .dmg even though the README already promises "macOS (ARM + Intel)". Add a native x86_64 build on the macos-13 Intel runner, swapping the committed arm64 libpdfium.dylib for the x86_64 one before bundling (mirroring the Ubuntu ARM swap) so the bundled framework matches the app. Verified locally with a native x86_64 build: produces LLM Wiki_0.6.7_x64.dmg whose main binary and bundled Frameworks/libpdfium.dylib are both x86_64. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Build & Releasematrix only builds an Apple Silicon (aarch64-apple-darwin) macOS bundle, so every release has shipped no Intel.dmg— even thoughREADME.mdalready advertises "macOS (ARM + Intel)" and ".dmg (Apple Silicon + Intel)". Intel Mac users have had nothing to download.Change
Add a second macOS matrix row that produces a native x86_64 build:
macos-13, the last GitHub-hosted Intel runner, so it's a native build (not a cross-compile from Apple Silicon), matching how the bundle was validated locally.libpdfium.dylibfor the already-committedlibpdfium-x86_64.dylib, mirroring the existing Use ARM64 pdfium binary (Ubuntu ARM only) step. This is required becausetauri.macos.conf.jsonalways bundlespdfium/libpdfium.dylib, whose committed content is arm64 — without the swap an x86_64 app would ship an arm64 pdfium and fail to load PDFs at runtime.Verify PDFium binary checksumsstep, soSHA256SUMSstill validates the committed (arm64)libpdfium.dylib.The existing
Install protoc (macOS)step already matchesmacos-*, so the new row gets protoc for free. Tauri names the two artifacts distinctly (*_aarch64.dmgvs*_x64.dmg), so there is no release-asset collision. No Tauri updater is configured (the app checks the GitHub Releases API directly), so a second macOS artifact needs nolatest.json/signature changes.Verification
Built locally on an Intel Mac with
npm run tauri build -- --target x86_64-apple-darwin(with the pdfium swap applied):LLM Wiki_0.6.7_x64.dmgContents/MacOS/llm-wiki→Mach-O 64-bit executable x86_64Contents/Frameworks/libpdfium.dylib→Mach-O 64-bit dynamically linked shared library x86_64🤖 Generated with Claude Code