fix scheduled import empty path handling - #632
Open
charliecai wants to merge 2 commits into
Open
Conversation
charliecai
marked this pull request as ready for review
August 2, 2026 08:47
charliecai
force-pushed
the
agent/fix-scheduled-import-path
branch
from
August 2, 2026 08:52
9bbac70 to
4129b64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<project>/raw/sourcesresolveImportPath()preserve empty values rather than interpreting them asraw/sourcesRoot cause
Both the settings draft and the project-opening flow replaced an empty scheduled-import path with
<project>/raw/sources. The asynchronous hydration step only overwrote that value when a saved configuration existed, so a project without one retained the internal default. Saving unrelated settings or switching projects could then persist it. Separately, the runtime resolver also treated an empty path asraw/sources.The previous managed-path check only covered selected project subdirectories, so an arbitrary path such as
<project>/inboxwas not rejected even though it is still inside the project.User impact
Users with no scheduled-import directory configured now keep an empty store value and see an empty field prompting them to choose an external directory. Existing project-managed values are cleared during hydration and on the next settings save. Enabled configurations cannot be saved with a missing or self-referential path, and the UI explains whether the selected directory is inside the project or contains it.
Validation
npm run test:mocks(118 files, 1739 tests)npm run build