Skip to content

fix: reject project-internal archive exports - #626

Merged
nashsu merged 1 commit into
nashsu:mainfrom
AndrewDongminYoo:fix/archive-export-containment
Aug 2, 2026
Merged

fix: reject project-internal archive exports#626
nashsu merged 1 commit into
nashsu:mainfrom
AndrewDongminYoo:fix/archive-export-containment

Conversation

@AndrewDongminYoo

Copy link
Copy Markdown
Contributor

Summary

  • Resolve archive export destinations before checking whether they are inside the project.
  • Cover lexically external paths that normalize back into the project.
  • Keep this security hardening separate from provider-routing changes in fix: align provider routing across app and API #590.

Validation

  • cargo test --manifest-path src-tauri/Cargo.toml export_rejects_lexically_external_destination_that_resolves_inside_project --quiet
  • cargo test --manifest-path src-tauri/Cargo.toml --lib --quiet (352 passed, 1 ignored)

@AndrewDongminYoo
AndrewDongminYoo marked this pull request as ready for review July 31, 2026 08:14
@nashsu
nashsu merged commit ca3c7e1 into nashsu:main Aug 2, 2026
3 checks passed
@AndrewDongminYoo
AndrewDongminYoo deleted the fix/archive-export-containment branch August 2, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants