fix: bound and validate review titles - #615
Draft
Xiangyu7 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The previous review-block regular expression allowed the title capture to cross line boundaries. If a model omitted the closing
---on a REVIEW header, the parser could consume the description and later review blocks as one oversized title.The updated parser rejects that malformed header instead of swallowing subsequent valid blocks. Full review explanations remain in the description; only the title is bounded.
Impact
Malformed model output can no longer turn an entire REVIEW payload into a title or contaminate later valid review suggestions. This also gives persistence layers a predictable title size without discarding the detailed explanation.
Validation
npm run test:mocks— 118 test files, 1722 tests passed