[float_bounded_axiomatic] fix the floor error typo - #27
Open
Robertboy18 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an unsoundness in the float_bounded_axiomatic floor absolute-error/ULP axiom (aerr_ulp_floor_correct) that previously allowed deriving contradictions (Issue #24). It updates the axiom to use absolute error on both the premise and the result, and adjusts the bound to a conservative e1 + 1, aligning with the already-proved unbounded development.
Changes:
- Redefines
aerr_ulp_floor(r1, e1)to the conservative bounde1 + 1. - Updates
aerr_ulp_floor_correctto useabs(proj(f1) - r1)in the premise andabs(proj(floor_ieee754(f1)) - floor(r1))in the conclusion. - Adds/updates the
proveitsummary output forfloat/float_bounded_axiomaticreflecting all proofs succeeding.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| float/float_bounded_axiomatic/aerr_ulp_floor.pvs | Fixes the floor axiom’s premise/conclusion to use absolute error and updates the bound to e1 + 1. |
| summaries/float-float_bounded_axiomatic.summary | Records the latest proof run summary showing the float_bounded_axiomatic library proofs succeeding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey! this fixes the floor typo from #24.
basically:
e1 + 1, which matches the already-proved version infloat_unboundedchecked it with PVS 8.1:
FALSErepro does not go through anymore./prove-all -do=float/float_bounded_axiomaticpasses all 344/344 proofspretty small fix, just making the axiom say what it was meant to say.
Closes #24