Skip to content

For #2892, Add cFE Time option to disable local 1hz processing packet… - #2893

Draft
alanc-gsfc wants to merge 2 commits into
nasa:devfrom
alanc-gsfc:fix-2892-time-disable-local-1hz-opt
Draft

alanc-gsfc wants to merge 2 commits into
nasa:devfrom
alanc-gsfc:fix-2892-time-disable-local-1hz-opt

Conversation

@alanc-gsfc

Copy link
Copy Markdown
Contributor

name: FSW Code Change
about: Flight Software code changes
labels: fsw

Description of Change

The purpose of this feature request is to create a cFE TIME module option (DISABLE_LOCAL_1HZ) to compile out the cFE TIME Local 1Hz Timer, Callback/ISR, and Task. These components are used to drive the local 1Hz processing in the cFE Time subsystem. Normally this means just setting up a timer to wake up a task at 1hz, which will send a packet to the cFE TIME main task to do call its 1Hz processing state machine.

Given a use case where there are multiple cFS instances running on a single operating system such as QNX, Linux, or VxWorks RTPs, we can save some resources by not including the timer, callback, and task. In their place, the packet that drives the 1hz state machine could be sent from:

  • The scheduler ( provided that necessary conditions are met such not using the FAKE tone option and driving the scheduler major frame from the time 1hz callback)
  • A cFS Instance configured as a TIME server. In this case, the message ID can be configured to be global and the TIME server will send this packet out to all time clients on the Software Bus Network.

Linked Issue

Closes #2892

Requirements Impact

  • Requirement ID(s):
  • Requirements updated as necessary
  • Existing requirements are still satisfied by this change

Testing Evidence

Unit Tests (UT Assert)

COSMOS Test Suite

Areas of Expertise Touched

  • ASTRO
  • CI/CD
  • COSMOS
  • Cybersecurity
  • Docker
  • EDS
  • Git
  • PSPs
  • SBN
  • SMP
  • Tables
  • TSN
  • Unit Tests
  • Other

Author Checklist

  • Linked GitHub issue is referenced above
  • Code has been formatted with .clang-format
  • Static analysis workflows ran and passed
  • Unit tests (UT Assert) updated/added to cover code changes
  • Unit test workflows ran and passed
  • COSMOS test suite was run; tests updated/added if relevant changes were made
  • Requirements have been reviewed; updated or confirmed still satisfied (see above)
  • Testing evidence is included above
  • Self-review of the diff completed

Reviewer Checklist

  • Code logic is correct and matches the stated intent
  • Code is readable, maintainable, and follows project conventions (ask your lead if you are unsure of where to find these conventions)
  • .clang-format has been applied
  • Static analysis results reviewed and acceptable
  • The change has been exercised by the unit tests (not just that tests pass — the new/changed code paths are actually covered)
  • COSMOS test suite was executed against this change and results reviewed (or confirmed N/A with justification)
  • Reviewer has independently verified the change behaves as described (e.g., by running the tests locally, reviewing CI output in detail, or performing additional ad-hoc testing as warranted)
  • Memory safety reviewed (allocation, bounds, lifetime, stack usage)
  • Requirements impact reviewed and appropriate
  • Error handling is appropriate
  • Appropriate Expert areas have been reviewed

Reviewer Testing Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cFE TIME option to disable Local 1Hz Timer, ISR, and Task

1 participant