Repository navigation
Fix 2868 fix time send cmd on client - #2882
Merged
alanc-gsfc merged 2 commits intoOct 29, 2026
Merged
Conversation
alanc-gsfc
force-pushed
the
fix-2868-fix-time-send-cmd-on-client
branch
from
October 27, 2026 13:04
f1b3860 to
aa809f4
Compare
alexandercalder
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: FSW Code Change
about: Flight Software code changes
labels: fsw
Description of Change
This changes the cFE TIME client configuration to not initialize or send the SEND_CMD_MID packet from the 1hz tone ISR. This is sent from both the server (correct) and any client (incorrect) when the TIME FAKE TONE option is also selected.
It is an obscure bug that only occurs if:
If the client is running in without a server for some reason, it will send out the SEND_CMD_MID packet but not be received by any component (the client does not subscribe)
Linked Issue
Closes #2868
Requirements Impact
Testing Evidence
I added a debug OS_printf statement when the cFE TIME server receives the SEND_CMD_MID packet.
The first log is when the cpu1 executable was started, run for a little while, then the cpu2 executable was started.
The cpu2 executable is configured as a TIME client.
You can see that after the cpu2 peer connects, the server receives two SEND_CMD_MID packets per second, because the client is sending the packet as well. If we had 4 clients, it would receive 5 of these packets per second.
This log is from after the fix:
You can see that after the cpu2 peer connects via SBN, the TIME Server continues to receive only one SEND_CMD_MID packet per second.
Unit Tests (UT Assert)
Unit tests are updated so the time subsystem coverage tests pass when configured as a client.
TIME Server (default) tests are unchanged.
COSMOS Test Suite
N/A - no relevant changes
Areas of Expertise Touched
Author Checklist
.clang-formatReviewer Checklist
.clang-formathas been appliedReviewer Testing Notes