Skip to content

Fix nasa#2880, Remove assignments that are never used - #2881

Merged
myc-yang merged 1 commit into
nasa:devfrom
myc-yang:2880-fix-useless-variable-assignments
Oct 27, 2026
Merged

myc-yang merged 1 commit into
nasa:devfrom
myc-yang:2880-fix-useless-variable-assignments

Conversation

@myc-yang

Copy link
Copy Markdown
Contributor

Describe the contribution

Testing performed
Static code analysis and Unit Tests

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • No impact to behavior

System(s) tested on

  • Hardware: PC
  • OS: Linux

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
Michael Yang / NASA/GSFC

@myc-yang
myc-yang force-pushed the 2880-fix-useless-variable-assignments branch from c94abc0 to e4e0034 Compare October 23, 2026 18:45
@myc-yang
myc-yang requested a review from jphickey October 26, 2026 13:08
@myc-yang
myc-yang marked this pull request as ready for review October 26, 2026 13:08

@jphickey jphickey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks OK.
This needs a rebase and that should hopefully fix the workflow fails

@myc-yang
myc-yang force-pushed the 2880-fix-useless-variable-assignments branch from e4e0034 to ac5dd04 Compare October 27, 2026 12:37
@myc-yang
myc-yang merged commit 1f16407 into nasa:dev Oct 27, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cFE files make variable assignments that prove to be useless

2 participants