Repository navigation
Fix nasa#2880, Remove assignments that are never used - #2881
Merged
myc-yang merged 1 commit intoOct 27, 2026
Merged
Conversation
myc-yang
force-pushed
the
2880-fix-useless-variable-assignments
branch
from
October 23, 2026 18:45
c94abc0 to
e4e0034
Compare
myc-yang
marked this pull request as ready for review
October 26, 2026 13:08
jphickey
requested changes
Oct 26, 2026
jphickey
left a comment
Contributor
There was a problem hiding this comment.
In general looks OK.
This needs a rebase and that should hopefully fix the workflow fails
myc-yang
force-pushed
the
2880-fix-useless-variable-assignments
branch
from
October 27, 2026 12:37
e4e0034 to
ac5dd04
Compare
jphickey
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Testing performed
Static code analysis and Unit Tests
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Michael Yang / NASA/GSFC