feat: Add EVA start time to QuickMap links - #1
Open
malaretv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time— the initial displayed timestartTimeandstopTime— an optional bounded playback rangeThis is useful because QuickMap uses
timeto initialize lighting and time-aware layers. Opening an EVA at its scheduled start therefore gives the external map meaningful temporal context.Future ideas
stopTimefrom AEGIS duration estimates, if that behavior is desired.Testing
npx vitest run src/tests/vitest/utils/quickMap.test.tsnpx tsc --noEmit --pretty false --project tsconfig.jsontimeparameter, by adding an EVA Start Time to the Apollo 14 example, and then clicking "View EVA in QuickMap"