feat: Resolve plugins via from_backend - #3822
Open
FBruzzesi wants to merge 3 commits into
Open
Conversation
FBruzzesi
commented
Jul 27, 2026
| backend: IntoBackend[Backend | PluginName], # noqa: ARG001 | ||
| impl: Implementation, | ||
| /, | ||
| ) -> TypeGuard[IntoBackend[PluginName]]: |
Member
Author
There was a problem hiding this comment.
I spent an unhealthy amount of time on this. @dangotbanned I am sure this is obvious to you, but it's still a bit mysterious for me
Member
There was a problem hiding this comment.
I will try to work through this with you soon 🙏
FBruzzesi
commented
Jul 27, 2026
Comment on lines
+1659
to
+1660
| backend: IntoBackend[Backend | PluginName], # noqa: ARG001 | ||
| impl: Implementation, |
Member
Author
There was a problem hiding this comment.
impl is a parameter rather than re-derived here since in eager_namespace it's already computed (it's not in _io_method)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #3753 (comment)
What type of PR is this? (check all applicable)