Improve mapping of SQL integer types to C corresponding types - #370
Open
mloskot wants to merge 14 commits into
Open
Improve mapping of SQL integer types to C corresponding types#370mloskot wants to merge 14 commits into
mloskot wants to merge 14 commits into
Conversation
mloskot
changed the title
mloskot
changed the title
mloskot
added a commit
to Cadcorp/nanodbc
that referenced
this pull request
Jan 25, 2023
Porting nanodbc#370 Fine-grained mapping of SQL integer types to C corresponding types Add reading of missing C data types for integers Distinguish SQL_C_BIT data type for reading Prefer mapping of SQL_C_* types to fixed-width integer types Ensure SQL_C_SHORT and SQL_C_LONG are mapped to fixed-width variant types test: Catch up with improved integer types mapping Refine reading of SQL_C_TINYINT into int8_t instead of int16_t The int16_t may lead to numeric garbage for values at range boundaries. tests: Refine SQLite tests for integer types
mloskot
added a commit
to Cadcorp/nanodbc
that referenced
this pull request
Jan 26, 2023
Porting nanodbc#370 Fine-grained mapping of SQL integer types to C corresponding types Add reading of missing C data types for integers Distinguish SQL_C_BIT data type for reading Prefer mapping of SQL_C_* types to fixed-width integer types Ensure SQL_C_SHORT and SQL_C_LONG are mapped to fixed-width variant types test: Catch up with improved integer types mapping Refine reading of SQL_C_TINYINT into int8_t instead of int16_t The int16_t may lead to numeric garbage for values at range boundaries. tests: Refine SQLite tests for integer types Fix size of output value read for SQL_C_BIT data
mloskot
force-pushed
the
ml/fine-grain-numeric-types-mapping
branch
2 times, most recently
from
February 4, 2023 14:01
e41d33a to
6b7c309
Compare
mloskot
force-pushed
the
ml/fine-grain-numeric-types-mapping
branch
from
August 2, 2023 20:17
6b7c309 to
11430cf
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| case SQL_C_SLONG: | ||
| result = *(ensure_pdata<int32_t>(column)); | ||
| { | ||
| long d = *(ensure_pdata<int32_t>(column)); |
Check warning
Code scanning / PREfast
The variable 'd' does not change after construction, mark it as const (con.4).
The int16_t may lead to numeric garbage for values at range boundaries.
Types, especially SQL_TINYINT, can be signed or unsigned which is implementation-specific behaviour. The best bet is to ask column descriptor for column signedness and refine output C type and buffer size.
mloskot
force-pushed
the
ml/fine-grain-numeric-types-mapping
branch
from
August 2, 2023 21:04
11430cf to
74cf4b5
Compare
mloskot
force-pushed
the
ml/fine-grain-numeric-types-mapping
branch
from
August 2, 2023 21:07
74cf4b5 to
3a86690
Compare
|
This work looks good. The work was done and approved over 3 years ago. Is it going to make it into a release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Closes #369