dv: ignore advertised routes whose cost overflows into reachability - #221
Open
Harsh23Kashyap wants to merge 1 commit into
Open
Harsh23Kashyap wants to merge 1 commit into
Harsh23Kashyap wants to merge 1 commit into
Conversation
updateRib adds the local link cost to the advertised cost without checking for overflow. A neighbor advertising Cost = MaxUint64 wraps to 0 after the addition, and the route is accepted with the best possible cost instead of being treated as unreachable. Only accept advertised costs with enough headroom below CostInfinity for the local link cost; anything else is unreachable.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220
What
updateRib, only add the local link cost when the advertised cost has headroom belowCostInfinity; otherwise the route stays unreachable. Applies to both the normal and poison-reverse (OtherCost) paths.MaxUint64-cost advertisement no longer produces a cost-0 route.Evidence
Before (on main):
After (this branch):
Full
go test ./...green.