Conversation
Standard and keyed modes share one IO implementation through compile time strategy types instead of Option branches. Public keyed APIs are unchanged. Adds comments and hash_strategy naming for clarity. Fixes dead_code warnings in validate only builds.
Trim comments to bao-tree style, hide strategy types from rustdoc, and add Keyed decode type aliases. Public keyed APIs unchanged.
This way we don't have a public API that we have to hide. Also less generics noise. I don't have an use case for somebody actually supplying another strategy. In fact I think it is easy to get this wrong so I would prefer people to fork in that case.
keyed is a rather niche use case and I don't want to burden CreateOutboard implementers with this. We can add them later once/if we have lots of keyed outboard users.
|
Got this work wired in and seems to be working as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds keyed bao methods. Builds on #77 and
makes a bunch of small modifications. Logic is the same though.