router: preserve LONGTEXT and LONGBLOB column types in MRS - #744
Open
cuishuang wants to merge 1 commit into
Open
router: preserve LONGTEXT and LONGBLOB column types in MRS#744cuishuang wants to merge 1 commit into
cuishuang wants to merge 1 commit into
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
Bot
added
the
OCA Required
Author
|
signed. 
|
Author
|
recheck cla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Fixes the MySQL REST Service metadata mapping for MYSQL_TYPE_LONG_BLOB.
The helper now returns:
The existing TINY_BLOB, MEDIUM_BLOB and BLOB mappings are preserved.
Why is it needed?
MYSQL_TYPE_LONG_BLOB is used by the MySQL C API for both LONGBLOB and LONGTEXT.
The previous implementation returned BLOB unconditionally, causing LONGTEXT metadata to be exposed as BLOB and losing the original LONGBLOB type name.
How was it tested?
mysql-test/scripts/ci/mtr.shpasses locallyContributor checklist
scripts/ci/format.sh)AI assistance
If AI assistance was used, describe the tool(s) and extent of use:
AI assistance was used for test generation and review. The final code and test changes were manually checked, formatted, and syntax-validated.
Areas touched
router, mysql_rest_service, mysql-test/suite/router