Add dose estimation UI - #2175
Draft
mockoocy wants to merge 2 commits into
Draft
Conversation
Since each site may define their own way to estimate dose absorbed by the crystal, it is important to move this logic to the backend. This way it becomes much easier to make it accessible for all the members of the collaboration and reduces the friction during subsequent rebases. It has another upside of making it easier for scientists to tinker with the calculations.
mockoocy
marked this pull request as draft
August 3, 2026 11:30
Includes removal of unused properties from dose estimation adapter.
mockoocy
force-pushed
the
maxiv-dose-calculation
branch
from
August 3, 2026 11:33
f218aab to
7173b00
Compare
Contributor
Author
|
Tests fail, but that's expected (it needs the mxcubecore PR to be mergedd first) |
Member
|
Thanks, really nice that you guys made a PR with this. I/we think what you presented on the last MXCuBE meeting looked really promising. We would just need to have another look here, but as far as the concept goes I think we can merge this more or less as it is and then possibly work from there for any smaller adjustments. |
Member
|
Would you mind attaching some screenshots on how it looks like in the mean time ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires mxcube/mxcubecore#1643 to be merged first.
It adds UI for dose estimation, dose estimation logic is being handled entirely by derivatives of
AbstractDoseEstimatorhardware object on mxcubecore side.