Skip to content

fixing modal not hiding because of the animation #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolaslazzos wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixing modal not hiding because of the animation #107

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2b459c
fixing modal not hiding because of the animation
nicolaslazzos Mar 5, 2021
549ce13
improving state checking when layout is triggered
nicolaslazzos Mar 8, 2021
40c9375
Add prop to block Menu hide
ManuelGarciaMasjoan Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class Menu extends React.Component {

// Start menu animation
_onMenuLayout = (e) => {
if (this.state.menuState === STATES.ANIMATING) {
if ([STATES.HIDDEN, STATES.ANIMATING].includes(this.state.menuState)) {
Comment thread
nicolaslazzos marked this conversation as resolved.
Outdated
return;
}

Expand Down