Repository navigation
Don't build the vfwcap capture device on Windows - #102
Merged
Merged
Conversation
Video for Windows capture (vfwcap) links avicap32.dll and msvfw32.dll, which Windows Server Core doesn't have, so an executable linked with ffmpeg couldn't start in a Server Core container. The DirectShow and gdigrab capture devices are still built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped platform condition correctly addresses the unavailable Server Core DLL dependencies without affecting other builds.
0 open findings
What changed in this PR
Disables FFmpeg’s legacy vfwcap input device on Windows to support Windows Server Core containers.
Changes:
- Adds a Windows-specific FFmpeg configuration flag.
- Leaves other platforms and Windows capture devices unchanged.
| File | Description |
|---|---|
Makefile |
Applies --disable-indev=vfwcap only on Windows builds. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FFmpeg's Video for Windows capture device (
vfwcap) linksAVICAP32.dllandMSVFW32.dll. Windows Server Core doesn't have them, so an executable linked with go-media's static FFmpeg fails to start in amcr.microsoft.com/windows/servercorecontainer, with0xC0000135(DLL not found).This was found building go-omodie's Windows image (djthorpe/go-omodie#21). Every other system DLL the executable loads is in Server Core.
On Windows, FFmpeg is now configured with
--disable-indev=vfwcap. Video for Windows is the legacy capture API, and the DirectShow (dshow) and screen (gdigrab) capture devices are still built. Other platforms are unchanged.Test plan
make -n ffmpeg-configureadds--disable-indev=vfwcaponly whenOSiswindows.