fix(fleet): build what was pushed, and stop calling a good Mac install a failure - #5
Merged
Merged
Conversation
…l a failure The Windows refresh repairs a drifted `origin` (Blade still pointed at the pre-move sheehanmunim/t3code, where `main` does not resolve) and now refuses to build a stale checkout instead of shipping whatever commit the machine sat on under the new version number. The Mac relaunch treats a fresh PID as success. Gating it on an AppleScript System Events probe - which needs an Automation grant the installing shell may not have - reported a good install as a failure. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
size:M
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Windows refresh repoints a drifted remote, or refuses to build. Blade's checkout still had
originon the pre-movesheehanmunim/t3code, wheremaindoes not resolve. The fetch failed,rev-parseerrored, and the script carried on and built whatever commit that machine was sitting on — shipping a day-old build stamped with the new version number. It now repairs the remote URL, and exits non-zero rather than building a stale checkout.Mac relaunch trusts a fresh PID. The relaunch loop only reported success if an AppleScript
System Eventsprobe worked, which needs an Automation grant the installing shell may not have. A perfectly good install was reported as "Mac relaunch failed — no fresh MT Code process after open". Activation is now best-effort; the fresh process is the proof.Why
Today's fleet run installed 0.0.34 on all three machines, but the Windows pair built from
bba238ccd— a day behind — and the Mac reported failure after a successful install.