Skip to content

CI: fix testdata: broken NRW Hausumringe dataset URL - #30

Open
neteler wants to merge 8 commits into
mainfrom
test_fix_nrw_new_dataset
Open

CI: fix testdata: broken NRW Hausumringe dataset URL#30
neteler wants to merge 8 commits into
mainfrom
test_fix_nrw_new_dataset

Conversation

@neteler

@neteler neteler commented Jun 30, 2026

Copy link
Copy Markdown
Member

Replace huge 859.7 MB file hu_EPSG4647_Shape.zip (which no longer exists within openNRW) with a 70 MB gru_vereinf_05314000_Bonn_EPSG25832_GeoPackage.zip file from https://www.opengeodata.nrw.de/produkte/geobasis/lk/akt/gru_vereinfacht_gpkg/

Fixes #29 and probably also fixes #5

Requires #28

Replace huge 859.7 MB file `hu_EPSG4647_Shape.zip` (which no longer exists in openNRW) with 70 MB `gru_vereinf_05314000_Bonn_EPSG25832_GeoPackage.zip` file from <https://www.opengeodata.nrw.de/produkte/geobasis/lk/akt/gru_vereinfacht_gpkg/>
@neteler
neteler requested a review from anikaweinmann June 30, 2026 14:18
@neteler neteler self-assigned this Jun 30, 2026
@neteler neteler added the bug Something isn't working label Jun 30, 2026

@mmacata mmacata left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci

@neteler
neteler marked this pull request as draft June 30, 2026 15:22
@neteler neteler removed their assignment Jul 1, 2026
@neteler

neteler commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

@anikaweinmann As not being very familiar with the test, I don't manage to complete this PR. If possible, please continue it.

@anikaweinmann

Copy link
Copy Markdown
Member

The tests are running in grass -c epsg:3358 /grassdb/nc_spm_empty. I can try if I find the problem

@neteler

neteler commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

grass -c epsg:3358

I guess that EPSG:25832 collides with EPSG:3358 (can the former be reprojected into the latter?).
Maybe change it to use --tmp-location, and with the EPSG code of the dataset?

@neteler

neteler commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

OpenCode Deepseek v4 Flash kindly changed in 78e3dc7:

  1. download_urls.py: Added BUILDINGS_LAYERS = {"NW": "GebauedeBauwerk"} - the new NRW dataset is a multi-layer GPKG (cadastral data), and GebauedeBauwerk is the buildings layer (layer index 2, not the default layer 0 Flurstueck)
  2. v.alkis.buildings.import.py:
  • import_single_alkis_source() now accepts an optional layer parameter
  • The three v.import calls use a shared options dict that includes layer when provided
  • main() reads the layer name from BUILDINGS_LAYERS.get(fs)` and passes it through

@neteler

neteler commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

For the CI error, see mundialis/github-workflows#83

@neteler
neteler marked this pull request as ready for review July 20, 2026 18:24
neteler and others added 3 commits July 20, 2026 20:24
The old check required building footprints to cover the entire region
within 25m on all sides. This is unrealistic for discrete building
features in large regions. Changed to match the documented intent:
data should overlap with at least 50% of the region.
@neteler

neteler commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

Locally the NW test now works, in the correct EPSG:25832 project/mapset:

GRASS openNRW_epsg25832/test:v.alkis.buildings.import > python test_v_alkis_buildings_import_NW.py
python: can't open file '/home/mneteler/software/mundialis_repos/v.alkis.buildings.import/test_v_alkis_buildings_import_NW.py': [Errno 2] No such file or directory
GRASS openNRW_epsg25832/test:v.alkis.buildings.import > cd testsuite/ ; python test_v_alkis_buildings_import_NW.py
WARNING: Please update the usage of <g.proj>: option <location> has been
         renamed to <project>
Running test for NW AOI and federal state file input...

Downloading ALKIS building data (NW)...
Importing ALKIS buildings data (NW)...
Rename vector <test_output_167224_NW> to <test_output_167224>
Importing ALKIS buildings data <test_output_167224> done.
Cleaning up...
/usr/lib64/python3.14/multiprocessing/resource_tracker.py:475: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown: {'/mp-vbplet_8'}
  warnings.warn(
/usr/lib64/python3.14/multiprocessing/resource_tracker.py:475: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown: {'/mp-puhepwjq'}
  warnings.warn(

Running test for NW AOI and federal state file input done.
.Running test for NW region flag...

Downloading ALKIS building data (NW)...
Importing ALKIS buildings data (NW)...
Rename vector <test_output_167224_NW> to <test_output_167224>
Importing ALKIS buildings data <test_output_167224> done.
Cleaning up...
/usr/lib64/python3.14/multiprocessing/resource_tracker.py:475: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown: {'/mp-cgy1ognv'}
  warnings.warn(
/usr/lib64/python3.14/multiprocessing/resource_tracker.py:475: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown: {'/mp-naqgtuk_'}
  warnings.warn(

Running test for NW region flag done.
.Running test for NW AOI...

Downloading ALKIS building data (NW)...
Importing ALKIS buildings data (NW)...
Rename vector <test_output_167224_NW> to <test_output_167224>
Importing ALKIS buildings data <test_output_167224> done.
Cleaning up...
/usr/lib64/python3.14/multiprocessing/resource_tracker.py:475: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown: {'/mp-jmah6q0_'}
  warnings.warn(
/usr/lib64/python3.14/multiprocessing/resource_tracker.py:475: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown: {'/mp-zrb1_4uq'}
  warnings.warn(

Running test for NW AOI done.
.OK

----------------------------------------------------------------------
Ran 3 tests in 223.990s

OK

Apparently the globally set AOI now fails (it doesn't make sense anyway in the NC projection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

testdata: broken NRW Hausumringe dataset URL and fix suggestion Runtime test

3 participants