Conversation
|
@Dante-dan is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an always-visible green completion action to issue details. Clicking it saves the Done status before dismissing the card; a failed save keeps the issue open. Regular pages return to the issue list, previews close, and standalone desktop issue windows close.
The existing action was only visible when a host supplied
onDone, and dismissed immediately after starting the mutation. This change keeps the existing issue mutation and status behavior rules, adds pending feedback, and supplies dismissal callbacks at the missing host boundaries. Already-done issues close without another write.Related Issue
Closes #9009
Type of Change
Changes Made
How to Test
Verified revision:
9a8fefcd203079f8a21d4876d3a0f35ec628114a.pnpm typecheck: 10/10 tasks successful (Turbo cache).pnpm lint: 7/7 tasks successful, with existing warnings.pnpm test: failed on a 5-second text-contrast timeout and Vitest fork startup timeouts. The original text-contrast suite passed independently with one worker (23 tests).This is a draft while visual QA evidence is completed. The completion behavior has component coverage; full backend/E2E verification remains outstanding.
Checklist
AI Disclosure
AI tool used: OpenAI Codex (gpt-6.1-sol)
Prompt / approach: Under the user's direction to follow up eligible issues, I used the feature request in #9009 to implement an always-visible completion button, traced the shared view and its web/desktop hosts, reviewed mutation success/error handling, and ran the repository checks and regression suites. This describes the AI-assisted approach, not a verbatim historical user prompt.
Screenshots (optional)
Before/after screenshots are pending; the checklist remains unchecked.