Repository navigation
fix: accept expect.soft.poll as a valid assertion - #524
Merged
mskelton merged 1 commit intoOct 29, 2026
Merged
Conversation
Playwright 1.61 supports soft polling assertions. Recognize expect.soft.poll(...) as a valid expect chain and count it as an assertion, while still rejecting unsupported orders such as expect.poll.soft. Fixes mskelton#519
mskelton
approved these changes
Oct 29, 2026
mskelton
enabled auto-merge (squash)
October 29, 2026 01:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Playwright 1.61 supports soft polling assertions:
await expect.soft.poll(() => value).toBe(expected).valid-expectreported that chain as an unknown modifier, andexpect-expectdid not count it as an assertion.expect.soft.poll(...)is now a valid expect chain and counts as an assertion, including computed forms such asexpect["soft"]["poll"](...). Chains Playwright does not support (expect.poll.softandexpect.soft(...).poll) stay invalid.Fixes #519
Test plan
valid-expect, andexpect-expecttests forexpect.soft.pollmissing-playwright-await,no-useless-await,no-standalone-expect,prefer-ending-with-an-expect,max-expects,require-soft-assertions,no-conditional-expect,prefer-to-be,prefer-strict-equal,no-useless-not)yarn testyarn format:check && yarn lint && yarn typecheck