Skip to content

Chore: moving unused wrappers to development branches - #195

Merged
kzsigmond merged 7 commits into
mainfrom
189-chore-move-unused-wrappers-to-development-branches
Apr 30, 2026
Merged

kzsigmond merged 7 commits into
mainfrom
189-chore-move-unused-wrappers-to-development-branches

Conversation

@kzsigmond

Copy link
Copy Markdown
Contributor

This pull request removes several wrapper and utility scripts related to quantum chemistry integrations, particularly those interfacing with HORTON and Psi4, as well as their associated tests. The main focus is on cleaning up and removing deprecated or unsupported code, especially for external quantum chemistry wrappers and compatibility hacks. This simplifies the codebase and eliminates dependencies on legacy or unsupported Python versions.

Note: the HORTON and Psi4 wrappers will be moved to development branches for future reference. If these wrappers become important over time, they should be integrated into the interface submodule as that handles the APIs to other packages.

The most important changes are:

Removal of HORTON and Psi4 wrappers:

  • Deleted the horton_gaussian_fchk.py, horton_hartreefock.py, psi4.py, and trial_loc.py scripts from fanpy/tools/wrapper, removing code for generating integrals and running Hartree-Fock calculations using HORTON and Psi4, as well as a localization script. [1] [2] [3] [4]
  • Removed the python_wrapper.py script, which provided a workaround for running HORTON via a subprocess with a different Python interpreter.

Test suite cleanup:

  • Removed the test file test_tools_wrapper_psi4.py, which tested the Psi4 wrapper.
  • Cleaned up test_wrapper_python_wrapper.py, removing imports and tests related to the deleted wrapper scripts, and eliminating code that checked for HORTON dependencies and tested the HORTON wrappers. [1] [2]

Minor documentation cleanup:

  • Removed the module docstring from fanpy/tools/wrapper/__init__.py, reflecting the removal of wrapper modules.

this script does not have any functions or classes
that fanpy relies on. It also does not use any
fanpy functionality. It is likely a remnant of
past development that should not be part of Fanpy.
This only houses utility functions used in the PySCF interface
@kzsigmond kzsigmond added this to the v2.0.0 milestone Apr 30, 2026
@kzsigmond kzsigmond self-assigned this Apr 30, 2026
@kzsigmond kzsigmond linked an issue Apr 30, 2026 that may be closed by this pull request
3 tasks
@kzsigmond
kzsigmond merged commit d186ec2 into main Apr 30, 2026
3 checks passed
@kzsigmond
kzsigmond deleted the 189-chore-move-unused-wrappers-to-development-branches branch April 30, 2026 19:28
@kzsigmond

Copy link
Copy Markdown
Contributor Author

The Psi4 wrapper has been moved to the psi4-wrapper branch.

@kzsigmond

Copy link
Copy Markdown
Contributor Author

The Horton wrapper has been moved to horton-wrapper branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chore: move unused wrappers to development branches

2 participants