Fix CodeQL/AI code-quality findings (unused variables, cls naming) - #215
Merged
Conversation
Copilot created this pull request from a session on behalf of
MichaIng
July 19, 2026 19:18
View session
MichaIng
marked this pull request as ready for review
July 19, 2026 19:19
MichaIng
reviewed
Jul 20, 2026
MichaIng
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved 4 open findings surfaced by the code-quality/findings API (CodeQL + AI analysis).
py/not-named-clsMotionEyeClient.is_file_type_imageandis_file_type_movieare@classmethods but named their first parameterself. Renamed toclsper PEP8, including the internal call site.py/unused-local-variabletest_cannot_connectdefined alogin_handlercoroutine that was never passed to a server or otherwise used (the test connects to a bare closed socket). Removed the dead code.py/unused-global-variabletests/test_client.pydeclared a module-level_LOGGERthat was never referenced. Removed it along with the now-unusedloggingimport.No functional or behavioral changes — all fixes are naming/dead-code cleanup.