CSHARP-6125: Reject non-collection inner sequences in LINQ Join/LeftJoin - #2095
Merged
Conversation
…oin (mongodb#2075) * CSHARP-6125: Reject non-collection inner sequences in LINQ Join/LeftJoin * CSHARP-6125: Add Join rejection tests and correct LeftJoin XML docs (cherry picked from commit 1b7da30)
damieng
requested review from
BorisDog and
sanych-sun
and removed request for
a team and
BorisDog
August 10, 2026 14:35
sanych-sun
approved these changes
Aug 10, 2026
sanych-sun
left a comment
sanych-sun
left a comment
Member
There was a problem hiding this comment.
LGTM. The current PR is nothing more than a clean cherry-pick of PR #2075.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2075 to
v3.x(cherry-pick of 1b7da30, clean, no conflicts).These kinds of sequences do not translate correctly and CSHARP-6017 inadvertently let them through instead of continuing to throw.