fix(runtime): enable SSR remote-entry retry and URL failover - #4968
Open
dmchoi77 wants to merge 2 commits into
Open
fix(runtime): enable SSR remote-entry retry and URL failover#4968dmchoi77 wants to merge 2 commits into
dmchoi77 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 3e9d2f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13639e3681
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Node.js/SSR remote-entry transport failures that currently bypass the
loadEntryErrorlifecycle.loadEntryNodenow follows the same retryableRUNTIME_008path as the browser loader, and the Node loader receivesgetEntryUrlso retry-plugin URL rewrites (domain failover and cache-busting queries) are applied during SSR as well.Remote-entry execution failures remain non-retryable. The Node SDK now marks transport failures as
ScriptNetworkErrorand execution failures asScriptExecutionError; hook/configuration failures retain their original errors.The change reuses the existing runtime error lifecycle and browser error handling pattern. No new public utility or retry API is introduced.
Regression coverage verifies:
loadEntryErrorand can recover with a rewritten URL.RUNTIME_008.createScripthook failures are not misclassified as network failures.Validation
All commands below were run with Node.js
24.19.0and pnpm10.28.0:Related Issue
Closes #4963
Types of changes
Checklist