Skip to content

mcp: a canceled write on IOTransport/StdioTransport cannot leave the write queue #1498

Closed

Description

@Tangerg

Checklist

  • I searched the existing issues, and this has not been reported before.
  • This is a real problem that I ran into myself, using the latest release of the SDK.
  • I ran into it in a production system, not in a toy example, a benchmark, or an automated or AI-driven scan of the code.
  • I (a human) examined the relevant SDK code, and wrote or reviewed every line of this report. It is not unreviewed AI output.
  • This report is brief and concise, and sticks to the facts needed to understand the problem.

What happened?

ioConn.Write checks the context only before taking its write mutex. If a write is blocked because the peer stopped reading, another Write whose context is canceled keeps waiting for the mutex instead of returning, and the blocked write itself cannot be interrupted by canceling its context. Callers that bound a request or notification with a deadline therefore hang until the peer reads again.

Expected: a write that has not started returns ctx.Err() without sending anything, and canceling the write in progress stops it (closing the connection, since a partial frame cannot be withdrawn).

AI assistance: the investigation was done with Claude; I reviewed the report and the SDK code.

How to reproduce

package main

import (
	"context"
	"fmt"
	"net"
	"time"

	"github.com/modelcontextprotocol/go-sdk/jsonrpc"
	"github.com/modelcontextprotocol/go-sdk/mcp"
)

func main() {
	local, peer := net.Pipe() // the peer never reads, as with a stalled server
	defer peer.Close()
	conn, err := (&mcp.IOTransport{Reader: local, Writer: local}).Connect(context.Background())
	if err != nil {
		panic(err)
	}

	write := func(name string, timeout time.Duration) {
		ctx, cancel := context.WithTimeout(context.Background(), timeout)
		defer cancel()
		done := make(chan error, 1)
		go func() { done <- conn.Write(ctx, &jsonrpc.Request{Method: name}) }()
		select {
		case err := <-done:
			fmt.Printf("%s: returned %v\n", name, err)
		case <-time.After(timeout + 2*time.Second):
			fmt.Printf("%s: still blocked 2s after its %v deadline\n", name, timeout)
		}
	}
	go write("active", 200*time.Millisecond)
	time.Sleep(50 * time.Millisecond)
	write("queued", 100*time.Millisecond)
	time.Sleep(time.Second)
}

Output with v1.8.0:

queued: still blocked 2s after its 100ms deadline
active: still blocked 2s after its 200ms deadline

Where did you hit this?

Frame hosts MCP plugin processes over stdio; when a plugin stopped reading, shutdown hung on pending writes, so Frame had to wrap SDK writes in its own cancelable layer.

Go MCP SDK version

v1.8.0 (also on main at f91620f)

Go version

go version go1.27.3 darwin/arm64

Logs

No response

Activity

  1. Tangerg commented on Nov 6, 2026

    @Tangerg
    ContributorAuthor

    #1499 now covers only the first half, as requested in review: a write that is still waiting for another write returns ctx.Err() without sending. With it, the repro above prints (with the final sleep raised to 3s so the second line appears):

    queued: returned context deadline exceeded
    active: still blocked 2s after its 200ms deadline
    

    The same holds end to end. With a server that stops reading, a CallTool with a 100ms deadline queued behind a blocked call returns after 100ms, never reaches the server, and the session keeps working. On v1.8.0 that call waits for the stall to end, and the server then runs it anyway.

    The second half stays open here: a write already in progress still blocks until the peer reads or the connection is closed. Closing the connection does unblock it.

    AI assistance: verified with Claude; I reviewed the results.

  2. guglielmo-san commented on Nov 6, 2026

    @guglielmo-san
    Contributor

    Closing as fixed by #1499 as there is no need/quick way of unblocking ongoing call for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions