Skip to content

testBreakout: pre-create implied victim directory in breakout test #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 1 commit into from
Jul 22, 2026
Merged

testBreakout: pre-create implied victim directory in breakout test #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ func testBreakout(untarFn string, tmpdir string, headers []*tar.Header) error {
if err := os.Mkdir(victim, 0o755); err != nil {
return err
}
// Avoid unrelated ownership failures when the cleaned path remains inside
// dest and requires an implied "victim" directory.
// See https://github.com/moby/go-archive/pull/69#issuecomment-5046037628
if err := os.Mkdir(filepath.Join(dest, "victim"), 0o755); err != nil {
return err
}
hello := filepath.Join(victim, "hello")
helloData, err := time.Now().MarshalText()
if err != nil {
Expand Down
Loading