Repository navigation
chore(deps): update aboutlibraries to v15 - #144
Merged
Merged
Conversation
v15 replaced the boolean flags on LibrariesContainer with a LibraryBadges object, so the bump alone does not compile: No parameter with name 'showDescription' found showDescription and showFundingBadges map onto badges.description and badges.funding. Both default to false in v15, so dropping the arguments would have quietly turned the descriptions and funding badges off rather than keeping what the screen showed before. Supersedes #130.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v15 replaced the boolean flags on
LibrariesContainerwith aLibraryBadgesobject, so the version bump on its own does not compile:The two flags map onto fields of that object, from
LibrariesVariant.ktat tag 15.2.0:descriptionandfundingboth default to false, so simply deleting the two arguments would have turned the library descriptions and the funding badges off.badges = LibraryBadges(description = true, funding = true)keeps what the screen showed before, and leaves version, author and license on their defaults, which is what v14 showed too.Testing Performed
Locally:
:app:compileDebugKotlin, thenspotlessCheck app:detekt :app:assembleDebug :app:testDebugUnitTest, all green.On device, Pixel 6a on Android 17, debug build installed and the About screen opened: every library renders name, version, author, description and licence chip, so the flag mapping is doing what it did on v14. App removed from the device afterwards.
:app:validateDebugScreenshotTestpasses but proves nothing here - there are no reference images committed at all, and neither screenshot test covers this screen. That gap is worth closing separately.Supersedes #130.