Skip to content

chore(deps): update aboutlibraries to v15 - #144

Merged
jamesarich merged 1 commit into
mainfrom
deps/aboutlibraries-v15
Sep 22, 2026
Merged

jamesarich merged 1 commit into
mainfrom
deps/aboutlibraries-v15

Conversation

@jamesarich

@jamesarich jamesarich commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

v15 replaced the boolean flags on LibrariesContainer with a LibraryBadges object, so the version bump on its own does not compile:

No parameter with name 'showDescription' found.
AboutLibrariesScreen.kt line 71

The two flags map onto fields of that object, from LibrariesVariant.kt at tag 15.2.0:

data class LibraryBadges(
    val version: Boolean = true,
    val author: Boolean = true,
    val description: Boolean = false,
    val license: Boolean = true,
    val funding: Boolean = false,
)

description and funding both default to false, so simply deleting the two arguments would have turned the library descriptions and the funding badges off. badges = LibraryBadges(description = true, funding = true) keeps what the screen showed before, and leaves version, author and license on their defaults, which is what v14 showed too.

Testing Performed

Locally: :app:compileDebugKotlin, then spotlessCheck app:detekt :app:assembleDebug :app:testDebugUnitTest, all green.

On device, Pixel 6a on Android 17, debug build installed and the About screen opened: every library renders name, version, author, description and licence chip, so the flag mapping is doing what it did on v14. App removed from the device afterwards.

:app:validateDebugScreenshotTest passes but proves nothing here - there are no reference images committed at all, and neither screenshot test covers this screen. That gap is worth closing separately.

Supersedes #130.

v15 replaced the boolean flags on LibrariesContainer with a LibraryBadges
object, so the bump alone does not compile:

  No parameter with name 'showDescription' found

showDescription and showFundingBadges map onto badges.description and
badges.funding. Both default to false in v15, so dropping the arguments
would have quietly turned the descriptions and funding badges off rather
than keeping what the screen showed before.

Supersedes #130.
@jamesarich
jamesarich added this pull request to the merge queue Sep 22, 2026
Merged via the queue into main with commit 248ac15 Sep 22, 2026
5 checks passed
@jamesarich
jamesarich deleted the deps/aboutlibraries-v15 branch September 22, 2026 18:53
@github-actions github-actions Bot mentioned this pull request Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant